Skip to content

fix: address straightforward open issue bugs#541

Closed
marandaneto wants to merge 1 commit intoPostHog:mainfrom
marandaneto:fix/straightforward-open-issue-bugs
Closed

fix: address straightforward open issue bugs#541
marandaneto wants to merge 1 commit intoPostHog:mainfrom
marandaneto:fix/straightforward-open-issue-bugs

Conversation

@marandaneto
Copy link
Copy Markdown
Member

💡 Motivation and Context

Fixes #526, #308, and #173.

This PR addresses the severe, straightforward bug reports from the open issue triage:

  • local feature flag 401 errors now include the server error and mention both project_api_key and personal_api_key instead of always blaming only personal_api_key
  • oversized queued events are acknowledged when dropped so flush() does not hang forever
  • disabled/no-op usage no longer requires an API key before returning early

New feature requests and more invasive fixes were intentionally left out.

💚 How did you test it?

  • uv run pytest posthog/test/test_consumer.py posthog/test/test_client.py posthog/test/test_feature_flags.py posthog/test/test_module.py -q
  • uv run ruff format --check .
  • uv run ruff check .

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran sampo add to generate a changeset file
  • Added the release label to the PR

@marandaneto
Copy link
Copy Markdown
Member Author

Superseded by split draft PRs: #542, #543, and #544.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading error message on local evaluation 401: always blames personal_api_key even when project_api_key is the problem

1 participant